Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: styles and components on PR pages #679

Merged
merged 3 commits into from
Jan 17, 2025
Merged

refactor: styles and components on PR pages #679

merged 3 commits into from
Jan 17, 2025

Conversation

andrewgolovanov
Copy link
Collaborator

@andrewgolovanov andrewgolovanov commented Jan 15, 2025 •
edited
Loading

Description:
This pull request makes the following fixes:

  • refactoring and fixing the common ButtonWithOptions component [Issue]
  • fix colors in Button themes
  • fix naming color tokens for buttons
    leads to a unified style instead of --canary-backround-button => --canary-button-background based on the design system
  • fix tag color for dark theme
  • minor adjustments and update tailwind config for button colors

Screenshots:
fix colors in Button themes

Before:
Disable state:
image
Success state:
image

After:
Disable state:
Arc 2025-01-16 19 46 22
Success state:
image

fix tag color for dark theme
Before
image
After:
image

@andrewgolovanov andrewgolovanov added the not-ready-for-review Add when you're still working on finalizing the changes in PR but still need to run all PR checks label Jan 15, 2025
@andrewgolovanov andrewgolovanov marked this pull request as draft January 15, 2025 16:40
@netlify Netlify
Copy link

netlify bot commented Jan 15, 2025 •
edited
Loading

✅ Deploy Preview for harness-xd-review ready!

Name Link
🔨 Latest commit c992a73
🔍 Latest deploy log https://app.netlify.com/sites/harness-xd-review/deploys/678a3fcd498e090008ff3326
😎 Deploy Preview https://deploy-preview-679--harness-xd-review.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@andrewgolovanov andrewgolovanov linked an issue Jan 16, 2025 that may be closed by this pull request
Extend and revise the ButtonWithOptions component #688
Closed
1 task
@andrewgolovanov andrewgolovanov changed the title feat: updating and finalizing styles for the PR Conversation page refactor: styles and components on PR pages Jan 16, 2025
@andrewgolovanov andrewgolovanov removed the not-ready-for-review Add when you're still working on finalizing the changes in PR but still need to run all PR checks label Jan 16, 2025
@andrewgolovanov andrewgolovanov marked this pull request as ready for review January 16, 2025 19:21
@andrewgolovanov andrewgolovanov force-pushed the fix-pr-conversation-styles branch from b939d84 to c95d513 Compare January 17, 2025 11:26
@andrewgolovanov andrewgolovanov force-pushed the fix-pr-conversation-styles branch from c95d513 to 8104c8c Compare January 17, 2025 11:27
@andrewgolovanov andrewgolovanov merged commit 17df592 into main Jan 17, 2025
10 checks passed
@andrewgolovanov andrewgolovanov deleted the fix-pr-conversation-styles branch January 17, 2025 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@3em 3em 3em approved these changes

@knagurski knagurski Awaiting requested review from knagurski knagurski is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Extend and revise the ButtonWithOptions component
2 participants
@andrewgolovanov @3em